fix(toolkit): endless wait if CDKToolkit stack is REVIEW_IN_PROGRESS
#23230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a `cdk bootstrap` operation is interrupted after the ChangeSet has been created, but before it is executed, the CDKToolkit stack will be left in the `REVIEW_IN_PROGRESS` state, which is a stable state until something or someone either executes or deletes the pending ChangeSet. This resulted in an endless (and silent, unless `cdk bootstrap` is executed in verbose mode) wait, as this was considered an "in progress" (aka unstable) state. This changes `REVIEW_IN_PROGRESS` to be treated as stable, while still debug-logging an indication that we are "ignoring" the existing ChangeSet.
RomainMuller
added
package/tools
|
|
aws-cdk-automation
previously requested changes
Dec 5, 2022
vvigilante
reviewed
Dec 5, 2022
| @@ -371,6 +371,14 @@ export async function stabilizeStack(cfn: CloudFormation, stackName: string) { | |||
| if (status.isInProgress) { | |||
| debug('Stack %s has an ongoing operation in progress and is not stable (%s)', stackName, status); | |||
| return undefined; | |||
| } else if (status.isReviewInProgress) { | |||
| // This may happen if a stack creation operation is interrupted before the ChangeSet execution starts. Recovering | |||
| // from this would requiring manual intervention (deleting or executing the pending ChangeSet), abd failing to do | |||
vvigilante
approved these changes
Dec 5, 2022
| // so will result in an endless wait here (the ChangeSet wont delete or execute itself). Instead of blocking | ||
| // "forever" we proceed as if the stack was existing and stable. If there is a concurrent operation that just | ||
| // hasn't finished proceeding just yet, either this operation or the concurrent one may fail due to the other one | ||
| // having made progress. Which is file. I guess. |
ryparker
approved these changes
Dec 6, 2022
|
Added a hold label so that you can choose to accept the typo fixes or not. |
Co-authored-by: Ryan Parker <me@ryanparker.dev>
RomainMuller
added
pr-linter/cli-integ-tested
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this pull request
Dec 9, 2022
aws#23230) If a `cdk bootstrap` operation is interrupted after the ChangeSet has been created, but before it is executed, the CDKToolkit stack will be left in the `REVIEW_IN_PROGRESS` state, which is a stable state until something or someone either executes or deletes the pending ChangeSet. This resulted in an endless (and silent, unless `cdk bootstrap` is executed in verbose mode) wait, as this was considered an "in progress" (aka unstable) state. This changes `REVIEW_IN_PROGRESS` to be treated as stable, while still debug-logging an indication that we are "ignoring" the existing ChangeSet.
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this pull request
Jan 20, 2023
aws#23230) If a `cdk bootstrap` operation is interrupted after the ChangeSet has been created, but before it is executed, the CDKToolkit stack will be left in the `REVIEW_IN_PROGRESS` state, which is a stable state until something or someone either executes or deletes the pending ChangeSet. This resulted in an endless (and silent, unless `cdk bootstrap` is executed in verbose mode) wait, as this was considered an "in progress" (aka unstable) state. This changes `REVIEW_IN_PROGRESS` to be treated as stable, while still debug-logging an indication that we are "ignoring" the existing ChangeSet.
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this pull request
Feb 22, 2023
aws#23230) If a `cdk bootstrap` operation is interrupted after the ChangeSet has been created, but before it is executed, the CDKToolkit stack will be left in the `REVIEW_IN_PROGRESS` state, which is a stable state until something or someone either executes or deletes the pending ChangeSet. This resulted in an endless (and silent, unless `cdk bootstrap` is executed in verbose mode) wait, as this was considered an "in progress" (aka unstable) state. This changes `REVIEW_IN_PROGRESS` to be treated as stable, while still debug-logging an indication that we are "ignoring" the existing ChangeSet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
cdk bootstrapoperation is interrupted after the ChangeSet has been created, but before it is executed, the CDKToolkit stack will be left in theREVIEW_IN_PROGRESSstate, which is a stable state until something or someone either executes or deletes the pending ChangeSet.This resulted in an endless (and silent, unless
cdk bootstrapis executed in verbose mode) wait, as this was considered an "in progress" (aka unstable) state. This changesREVIEW_IN_PROGRESSto be treated as stable, while still debug-logging an indication that we are "ignoring" the existing ChangeSet.