fix(eks): reuse chart name as chart dir for helmchart deployment from OCI repository

[psemeniuk]

Fixes #22341

It migrates assigning chart_dir from release name to chart name, to be consistent with helm-pull's target directory.

I also added to integration test yet another chart deployment of a different chart. Why it's separate? Because of the way of how testing flow is working - if i understand it correctly it provisions previous snapshot, and finally after that provisions a new version of assets and test code on top of existing. Thanks to that i'm unable to cover my case in existing chart deployment, because when i change release name it conflicts with previously deployed (during old snapshot provisioning) chart (UPDATE_FAILED (The following resource(s) failed to update: [Clustercharttestocichart9C188967]. ): Received response status [FAILED] from custom resource. Message returned: Error: b'Release "s3-chart-release" does not exist. Installing it now.\nError: rendered manifests contain a resource that already exists. Unable to continue with install: ServiceAccount "ack-s3-controller" in namespace "ack-system" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: key "meta.helm.sh/release-name" must equal "s3-chart-release": current value is "s3-chart"\n').

Actually i successfully ran the modified integration test, but i didn't commit changes caused by yarn integ command, because i don't know which i have to commit.

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Construct Runtime Dependencies:

• This PR adds new construct runtime dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
• Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

[comcalvi]

if you're not sure what integ test changes to commit, run git clean -fdx from the packages/@aws-cdk/aws-eks directory, then run yarn install && yarn build and then rerun the tests

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[comcalvi]

I was wrong, this is not a breaking change. However we do need some better docs to clarify what's happening with helm here.

[comcalvi]

It's worth mentioning exactly why this does what it does, for those less familiar with helm and its specifics. Can you put a comment above this line explaining why we need the repository here?

[psemeniuk]

I put extensive explanation above the rpartition line. This will be "good enough"?

Pull request has been modified.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 3218dad
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).