feat(core): allow asset bundling on docker remote host / docker in docker

[webratz]

Fixes #8799

This implements an alternative variant on how to put get files into bundling containers. This is more flexible in its use cases for complex Docker setup scenarios but more complex and slower. Therefore it is not enabled as a default, but as an additional option.

For details to the approach please refer to the linked issue.

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Construct Runtime Dependencies:

• This PR adds new construct runtime dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[mrgrain]

This is great! What I'm currently wondering is if this should be a prop, feature flag or ENV variable. 🤔

Having it as a prop feels odd in the sense that it's very environment dependent. But then we do the same with local bundling already. @rix0rrr do you have a view how these kind of options should be enabled/disabled?

[webratz]

did you get to a decision on how enabling of this mode should be implemented?

[mrgrain]

Still on it sorry. Had a busy week.

[mrgrain]

Okay I've arrived at the conclusion that a prop is the best option here. It's the only way to enable other uses as well, so if a team wants to implement this based on an environment variable they could do something like:

{
   fileCopyVariant: process.env.BUNDLING_FILE_COPY_VARIANT 
}

Similar applies to using a Context value.

Still need to think about naming, reviewing and manually testing this locally.

---

Apologies in advance but this PR will likely take me a couple more weeks. Just so you know in case your planning depends on it.

[webratz]

Sure, no problem. Feel also free to edit the branch / fork it again or so, if that helps you to speed up things. The overall important thing is the outcome in the end: A more flexible way that allows to use docker bundling in more situations than today.

[mrgrain]

I'm going back and fourth on the naming of things. Will need to sleep over it.

You can get started on the other changes, but mostly if you could make the build pass (rosetta documentation error), I can use this branch to do a full build and run some proper tests using Docker in Docker

[webratz]

updated names everywhere

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: c4b09ee
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).