fix(servicecatalog): incorrect objectkey produced from asset relative…

[wanjacki]

Currently when assets are nested in a directory, ProductStack is unable to parse the fileName and produces an incorrect template.
Since asset.fileName is the relative to the root of the cloud assembly, in which this asset source resides,
we need to call path.basename in order to get the actual name of the file before parsing it to generate the s3Filename

More details found in #23560

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

[wanjacki]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

This is a small change that fixes a bug, I added a corresponding unit test to verify this exact scenario and make sure it is working as intended now. Is it possible to be exempt from integ test changes here?

[padaszewski]

@corymhall
Hi, sorry for bothering, but You were reviewing this and if it were possible could You also take a quick look on this issue? I thought this would be fast merged but 2.60 is out and this is still open. I don't want this PR to go down because it is probably the last blocker for us.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[TheRealAmazonKendra]

@Mergifyio update

[mergify]

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/issue-label-assign.yml without workflows permission
err-code: 3FD2A

Pull request has been modified.

[TheRealAmazonKendra]

Mergify being Mergify. Re-approving.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: c493ddd
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).