fix(rds): database proxies use ids as their resource names directly (under feature flag) #23703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
|
|
aws-cdk-automation
previously requested changes
Jan 16, 2023
ymhiroki
changed the title
ymhiroki
changed the title
|
I added the testcase in integ.proxy.ts to pass the CI, however, it fails when I run How can I pass the CI or make the snapshot successfully? |
added 2 commits
January 17, 2023 13:13
ymhiroki
force-pushed
the
feature/rds-proxy-unique-resource-name
branch
from
2db2337 to
ce422a7
Compare
ymhiroki
changed the title
ymhiroki
changed the title
TheRealAmazonKendra
previously requested changes
Jan 17, 2023
There was a problem hiding this comment.
Thank you for your contribution! Just a couple comments on this:
- You'll need to update the integ test to use our
IntegTestconstruct and then add
cdkCommandOptions: {
deploy: {
args: {
rollback: true,
},
},
},
After the test case. See this test for a good example.
- The title of a fix should describe the bug, not the fix you're implementing. Please update the title.
Once we have a working build, we'll provide a more meaningful review.
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
1 similar comment
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
ymhiroki
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
…roxy-unique-resource-name
ymhiroki
force-pushed
the
feature/rds-proxy-unique-resource-name
branch
from
ec47433 to
d0d4c5c
Compare
mergify
bot
dismissed
TheRealAmazonKendra’s stale review
Pull request has been modified.
|
Thanks for your nice advice, @TheRealAmazonKendra ! I added snapshots for integration tests and finally passed the CIs. I beg your reviews. |
comcalvi
previously approved these changes
Feb 9, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
dismissed
comcalvi’s stale review
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
comcalvi
approved these changes
Feb 10, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18578
All Submissions:
Adding new Construct Runtime Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license