Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stepfunctions): task and heartbeat timeout specified by a path #23755

Merged
merged 10 commits into from
Jan 26, 2023
Merged

feat(stepfunctions): task and heartbeat timeout specified by a path #23755

merged 10 commits into from
Jan 26, 2023

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Jan 19, 2023 •
edited
Loading

Add support for dynamic timeouts referenced by a path in the state.

Closes #15531

All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jogold
feat(stepfunctions): timeoutSecondsPath and heartbeatSecondsPath
b0c243a 
Add support for dynamic timeouts referenced by a path in the state.
@gitpod-io
Copy link

gitpod-io bot commented Jan 19, 2023

@github-actions github-actions bot added the p2 label Jan 19, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team January 19, 2023 16:23
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jan 19, 2023
TheRealAmazonKendra
TheRealAmazonKendra previously requested changes Jan 19, 2023
View reviewed changes
packages/@aws-cdk/aws-stepfunctions/lib/states/task-base.ts Outdated
private readonly credentials?: Credentials;

constructor(scope: Construct, id: string, props: TaskStateBaseProps) {
super(scope, id, props);

if (props.timeout && props.timeoutSecondsPath) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid mutually exclusive props here. I'm thinking that we should deprecate the original props and do something here along the lines of the Schedule class.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should be the name of the new prop?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does taskTimeout and heartbeatTimeout make sense? Totally open to better ideas.

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 and removed p2 labels Jan 23, 2023
@mergify mergify bot dismissed TheRealAmazonKendra’s stale review January 25, 2023 09:20

Pull request has been modified.

@jogold jogold changed the title feat(stepfunctions): timeoutSecondsPath and heartbeatSecondsPath feat(stepfunctions): task and heartbeat timeout specified by a path Jan 25, 2023
jogold
jogold commented Jan 25, 2023
View reviewed changes
packages/awslint/lib/rules/durations.ts
@@ -3,6 +3,7 @@ import { Linter } from '../linter';

const DURATION_FQN = '@aws-cdk/core.Duration';
const DURATION_SUFFIX = /(Days|Milli(?:(?:S|s)econd)?s?|Sec(?:ond)?s?)$/;
const EXCLUDE_ANNOTATION_DURATION_PROP_TYPE = '[disable-awslint:duration-prop-type]';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to create this to avoid those errors for all props interfaces that extend TaskStateBaseProps. I think this is a better solution than adding all the exclusions in the package.json in aws-stepfunctions-tasks.

Build errors awslint:duration-prop-type 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.AthenaGetQueryExecutionProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.AthenaGetQueryExecutionProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.AthenaGetQueryResultsProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.AthenaGetQueryResultsProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.AthenaStartQueryExecutionProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.AthenaStartQueryExecutionProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.AthenaStopQueryExecutionProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.AthenaStopQueryExecutionProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.BatchSubmitJobProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.BatchSubmitJobProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.CallApiGatewayEndpointBaseProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.CallApiGatewayEndpointBaseProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.CallApiGatewayHttpApiEndpointProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.CallApiGatewayHttpApiEndpointProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.CallApiGatewayRestApiEndpointProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.CallApiGatewayRestApiEndpointProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.CallAwsServiceProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.CallAwsServiceProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.CodeBuildStartBuildProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.CodeBuildStartBuildProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.DynamoDeleteItemProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.DynamoDeleteItemProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.DynamoGetItemProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.DynamoGetItemProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.DynamoPutItemProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.DynamoPutItemProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.DynamoUpdateItemProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.DynamoUpdateItemProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EcsRunTaskProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EcsRunTaskProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EksCallProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EksCallProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrAddStepProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrAddStepProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrCancelStepProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrCancelStepProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrContainersCreateVirtualClusterProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrContainersCreateVirtualClusterProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrContainersDeleteVirtualClusterProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrContainersDeleteVirtualClusterProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrContainersStartJobRunProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrContainersStartJobRunProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrCreateClusterProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrCreateClusterProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrModifyInstanceFleetByNameProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrModifyInstanceFleetByNameProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrModifyInstanceGroupByNameProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrModifyInstanceGroupByNameProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrSetClusterTerminationProtectionProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrSetClusterTerminationProtectionProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrTerminateClusterProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EmrTerminateClusterProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EvaluateExpressionProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EvaluateExpressionProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EventBridgePutEventsProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.EventBridgePutEventsProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.GlueDataBrewStartJobRunProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.GlueDataBrewStartJobRunProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.GlueStartJobRunProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.GlueStartJobRunProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.LambdaInvokeProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.LambdaInvokeProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SageMakerCreateEndpointConfigProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SageMakerCreateEndpointConfigProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SageMakerCreateEndpointProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SageMakerCreateEndpointProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SageMakerCreateModelProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SageMakerCreateModelProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SageMakerCreateTrainingJobProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SageMakerCreateTrainingJobProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SageMakerCreateTransformJobProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SageMakerCreateTransformJobProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SageMakerUpdateEndpointProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SageMakerUpdateEndpointProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SnsPublishProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SnsPublishProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SqsSendMessageProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.SqsSendMessageProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.StepFunctionsInvokeActivityProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.StepFunctionsInvokeActivityProps.taskTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.StepFunctionsStartExecutionProps.heartbeatTimeout] property must be typed @aws-cdk/core.Duration 
@aws-cdk/aws-stepfunctions-tasks: error: [awslint:duration-prop-type:@aws-cdk/aws-stepfunctions-tasks.StepFunctionsStartExecutionProps.taskTimeout] property must be typed @aws-cdk/core.Duration

TheRealAmazonKendra
TheRealAmazonKendra approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0aa3956
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 26e48c7 into aws:main Jan 26, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jogold jogold deleted the sfn-timeout-path branch January 26, 2023 08:44
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@kichik kichik mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-stepfunctions): Support dynamic Task timeouts (TimeoutSecondsPath/HeartbeatSecondsPath)
3 participants
@jogold @aws-cdk-automation @TheRealAmazonKendra