Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(appsync): Populate construct name dynamically for lambda authorizer permission in appsync #23777

Merged
merged 10 commits into from
Jan 25, 2023
Merged

fix(appsync): Populate construct name dynamically for lambda authorizer permission in appsync #23777

merged 10 commits into from
Jan 25, 2023

Conversation

ranjith-jagadeesh
Copy link
Contributor

@ranjith-jagadeesh ranjith-jagadeesh commented Jan 21, 2023 •
edited
Loading

fixes #23434

All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 21, 2023

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jan 21, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team January 21, 2023 03:13
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Jan 21, 2023
@ranjith-jagadeesh ranjith-jagadeesh mentioned this pull request Jan 21, 2023
Closed
4 tasks
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 21, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@ranjith-jagadeesh ranjith-jagadeesh changed the title fix(aws-appsync): Populate construct name dynamically for lambda authorizer permission in appsync fix(appsync): Populate construct name dynamically for lambda authorizer permission in appsync Jan 21, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 21, 2023 04:44

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@MrArnoldPalmer MrArnoldPalmer self-assigned this Jan 23, 2023
MrArnoldPalmer
MrArnoldPalmer approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY for adding tests and reopening! 🔥

@mergify
Copy link
Contributor

mergify bot commented Jan 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 685858c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 92f02e9 into aws:main Jan 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ranjith-jagadeesh
Copy link
Contributor Author

TY for adding tests and reopening! 🔥

Thanks for reviewing and merging🔥

@ranjith-jagadeesh
Copy link
Contributor Author

@MrArnoldPalmer When new version of package @aws-cdk/aws-appsync-alpha will be released?

@MrArnoldPalmer
Copy link
Contributor

@ranjith-jagadeesh the appsync package is now stable and in aws-cdk-lib so no new versions of the alpha package will be released. This fix will go out in our next normally planned release, probably sometime next week.

@ranjith-jagadeesh ranjith-jagadeesh deleted the appsync-lambda-authorizer branch January 27, 2023 02:49
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertpitt robertpitt robertpitt approved these changes

@MrArnoldPalmer MrArnoldPalmer MrArnoldPalmer approved these changes

@owenmorgan owenmorgan owenmorgan approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@MrArnoldPalmer MrArnoldPalmer

Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-appsync): (Not able to attach a Lambda Authorizer to two GraphqlApi)
5 participants
@ranjith-jagadeesh @aws-cdk-automation @MrArnoldPalmer @robertpitt @owenmorgan