feat(core): Allow passing Docker build secrets #23778
Conversation
|
|
github-actions
bot
added
effort/small
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
mergify
bot
dismissed
comcalvi’s stale review
Pull request has been modified.
mergify
bot
dismissed
comcalvi’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
| @@ -54,6 +55,7 @@ export class Docker { | |||
| const buildCommand = [ | |||
| 'build', | |||
| ...flatten(Object.entries(options.buildArgs || {}).map(([k, v]) => ['--build-arg', `${k}=${v}`])), | |||
| ...flatten(Object.entries(options.buildSecrets || {}).map(([k, v]) => ['--secret', `id=${k},${v}`])), | |||
There was a problem hiding this comment.
@danwiltshire sorry for reaching you out in a already merged PR, but shouldn't it be id=${k},src=${v} instead? It seems to be that docker cli always expect it to be a key pair with key and value.
There was a problem hiding this comment.
Thanks for catching this @abilun! Would you be able to submit a follow-up PR to fix this?
There was a problem hiding this comment.
Hello, when used with DockerBuildSecret, its method(s) specify the src=.
DockerBuildSecret.fromSrc(...)
Happy for any changes to be made though.
Edit: There is another Issue #24691 asking for fromEnvironment which I partially completed before the repo refactor.
Partially closes #14910 and #14395
All Submissions:
Adding new Construct Runtime Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license