Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cognito): changing installLatestAwsSdk breaks Client Secret reference #23798

Merged
merged 4 commits into from
Feb 16, 2023

Commits on Jan 23, 2023

  1. fix(cognito): changing installLatestAwsSdk breaks Client Secret ref…

    …erence
    
    Because there wasn't previously a handler for `onUpdate` events, an
    empty object would be returned. When `installLatestAwsSdk` was changed
    to `false`, this was an update. Typically, updates aren't an issue
    because basically any other property being updated signifies a
    replacement. `installLatestAwsSdk` is just a very unique case where it
    doesn't (and where a user usually can't update it).
    
    When the empty object is returned, this results in an update failure in
    CloudFormation because the specific property isn't available.
    laurelmay committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    837b8b0 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Replace onCreate with onUpdate

    Per the documentation, `onUpdate` is used when `onCreate` is not
    defined. Since they're the same, we can just define `onUpdate`.
    
    https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.custom_resources.AwsCustomResource.html#oncreate
    laurelmay committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    ce0ddfb View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Configuration menu
    Copy the full SHA
    d5ff298 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Configuration menu
    Copy the full SHA
    2a98289 View commit details
    Browse the repository at this point in the history