Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloud9): support setting environment owner #23878

Merged
merged 8 commits into from
Feb 8, 2023
Merged

feat(cloud9): support setting environment owner #23878

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2a47f13
added property and unit test
pattasai Jan 26, 2023
43ded09
owner_props
pattasai Jan 31, 2023
85e85a7
support setting environment owner
pattasai Feb 2, 2023
c52b45e
support setting environment owner
pattasai Feb 3, 2023
a695cd5
support setting environment owner
pattasai Feb 3, 2023
beaf73c
fix readme error
pattasai Feb 6, 2023
4f014c1
fix readme
pattasai Feb 8, 2023
a4c5e8e
Merge branch 'main' into pattasai/add-owner-prop
mergify[bot] Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/@aws-cdk/aws-cloud9/lib/environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ export enum ImageId {
* Properties for Ec2Environment
*/
export interface Ec2EnvironmentProps {
/**
* OwnerArn
* @default
*/
readonly owner?: string;
/**
* The type of instance to connect to the environment.
*
Expand Down Expand Up @@ -182,6 +187,7 @@ export class Ec2Environment extends cdk.Resource implements IEc2Environment {
const c9env = new CfnEnvironmentEC2(this, 'Resource', {
name: props.ec2EnvironmentName,
description: props.description,
ownerArn: props.owner,
instanceType: props.instanceType?.toString() ?? ec2.InstanceType.of(ec2.InstanceClass.BURSTABLE2, ec2.InstanceSize.MICRO).toString(),
subnetId: this.vpc.selectSubnets(vpcSubnets).subnetIds[0],
repositories: props.clonedRepositories ? props.clonedRepositories.map(r => ({
Expand Down
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-cloud9/test/cloud9.environment.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ test('throw error when subnetSelection not specified and the provided VPC has no
test('can use CodeCommit repositories', () => {
// WHEN
const repo = codecommit.Repository.fromRepositoryName(stack, 'Repo', 'foo');

new cloud9.Ec2Environment(stack, 'C9Env', {
vpc,
owner: 'xyz',
clonedRepositories: [
cloud9.CloneRepository.fromCodeCommit(repo, '/src'),
],
Expand All @@ -90,6 +90,7 @@ test('can use CodeCommit repositories', () => {
// THEN
Template.fromStack(stack).hasResourceProperties('AWS::Cloud9::EnvironmentEC2', {
InstanceType: 't2.micro',
OwnerArn: 'xyz',
Repositories: [
{
PathComponent: '/src',
Expand Down