Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pipelines): write a GraphViz file with the pipeline structure #23908

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 30, 2023

Add a pipeline.dot file to the cloud assembly containing the graph structure of the pipeline.

This change is a chore, not a feat, as I want this to be a debugging aid, but I don't want to service feature requests on it.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add a `pipeline.dot` file to the cloud assembly containing the graph
structure of the pipeline.

This change is a `chore`, not a `feat`, as I want this to be a debugging
aid, but I don't want to service feature requests on it.
@rix0rrr rix0rrr requested a review from a team January 30, 2023 13:34
@rix0rrr rix0rrr self-assigned this Jan 30, 2023
@gitpod-io
Copy link

gitpod-io bot commented Jan 30, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team January 30, 2023 13:35
@github-actions github-actions bot added the p2 label Jan 30, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 30, 2023
let i = 0;
const sortedNodes = Array.prototype.concat.call([], ...x.sortedChildren());
for (const child of sortedNodes) {
recurse(child, `${indent} ${follow} `, i++ == x.nodes.size - 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one 🙂

@mergify
Copy link
Contributor

mergify bot commented Jan 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9569c7c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ec73c39 into main Jan 30, 2023
@mergify mergify bot deleted the huijbers/pipelines-dotfile branch January 30, 2023 20:48
@mergify
Copy link
Contributor

mergify bot commented Jan 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot pushed a commit that referenced this pull request Feb 4, 2023
…ine structure (#23908)" (#24006)

This reverts commit ec73c39.



Closes #23990 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
corymhall added a commit that referenced this pull request Feb 4, 2023
…ine structure (#23908)" (#24006)

This reverts commit ec73c39.

Closes #23990

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
rix0rrr added a commit that referenced this pull request Feb 6, 2023
…23908)

Add a `pipeline.dot` file to the cloud assembly containing the graph structure of the pipeline.

This change is a `chore`, not a `feat`, as I want this to be a debugging aid, but I don't want to service feature requests on it.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
rix0rrr added a commit that referenced this pull request Feb 6, 2023
…23908)

Add a `pipeline.dot` file to the cloud assembly containing the graph structure of the pipeline.

This change is a `chore`, not a `feat`, as I want this to be a debugging aid, but I don't want to service feature requests on it.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit that referenced this pull request Feb 6, 2023
…24030)

This is a re-roll of #23908 which had to be reverted in  #24006 because there are some cases where change set approval steps that are shared between two stacks would cause cyclic dependencies between those stacks that caused them to be mutually unsortable.

Solve this by adding a mode to the toposort routine that will proceed even if there are cyclic dependencies (which is used purely for rendering).

----

Add a `pipeline.dot` file to the cloud assembly containing the graph structure of the pipeline.

This change is a `chore`, not a `feat`, as I want this to be a debugging aid, but I don't want to service feature requests on it.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants