feat(cli): support for environment specific local context json file - fixes #23911

[mavwolverine]

I have added support for passing context variables through a file making reruns easier.

I have also ensured that values passed on command line, override the values passed in the json.

Closes #23911 .

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[mavwolverine]

I have never worked on nodejs so not sure how to write or update any relevant tests. If someone could take that up, that would be great.

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

[gitpod-io]

[peterwoodworth]

You can use both cdk.json and cdk.context.json to pass in and reference as context values - have you tried these methods out?

[mavwolverine]

@peterwoodworth the objective here is maintaining and passing environment specific cdk.context.json. Separate files like cdk.context.dev.json, cdk.context.stage.json, cdk.context.prod.json.

[TheRealAmazonKendra]

Thank you for your contribution! We are unable to provide a meaningful review until the build is passing.

[mavwolverine]

Thank you for your contribution! We are unable to provide a meaningful review until the build is passing.

@TheRealAmazonKendra Like I mentioned, I have no experience with NodeJS. So requesting someone to take it forward for writing the unit tests for the build to pass.

I can understand not accepting the PR since the build is failing. But not reviewing the change to take it forward when the contributor has explicitly mentioned it, I find a little demoralizing.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 0938464
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[RichiCoder1]

I can understand not accepting the PR since the build is failing. But not reviewing the change to take it forward when the contributor has explicitly mentioned it, I find a little demoralizing.

If you'd like to propose the change itself, I might recommend creating an RFC in https://github.com/aws/aws-cdk-rfcs and posting in the cdk.dev Slack. I'd encourage it too, as I'd be interested in this myself!

[TheRealAmazonKendra]

Thank you for your contribution! We are unable to provide a meaningful review until the build is passing.

@TheRealAmazonKendra Like I mentioned, I have no experience with NodeJS. So requesting someone to take it forward for writing the unit tests for the build to pass.

I can understand not accepting the PR since the build is failing. But not reviewing the change to take it forward when the contributor has explicitly mentioned it, I find a little demoralizing.

I missed that comment while scrolling through, so I apologize for not replying there. Didn't mean to ignore it.

Unfortunately, our core team doesn't have the capacity to contribute on issues that are p2's. However, if another community member would like to help on this, we certainly welcome that. I see you linked an RFC issue that already exists so that's a great first step. I would +1 the suggestion @RichiCoder1 made about posting in the cdk.dev slack channel to see if anyone there would like to assist on this PR.

dismissing to restart the stale-pr-bot clock.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/23912/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[karmabadger]

@aws-cdk-automation
can you reopen this?