Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cfnspec): support us-west-2 only services #23928

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jan 31, 2023

Some AWS services are only in us-west-2 region, while CDK uses the AWS CloudFormation resource specification from us-east-1 for generating L1.

This change adds suppport for resource specifications from additional regions, with an explicit allow list for services supported for this region.

Fixes #17893
Fixes #22565


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 31, 2023

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Jan 31, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team January 31, 2023 12:56
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 31, 2023
@mrgrain mrgrain force-pushed the mrgrain/feat/cfnspec-from-us-west-2 branch from 96e558d to 7d47333 Compare January 31, 2023 13:13
@mrgrain mrgrain marked this pull request as ready for review January 31, 2023 13:13
@mrgrain mrgrain force-pushed the mrgrain/feat/cfnspec-from-us-west-2 branch from 7d47333 to bd1191a Compare January 31, 2023 13:15
@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8b09a63
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9f1fc15 into aws:main Jan 31, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1
Projects
None yet
3 participants