fix(assertions): nested stacks inside non-root stages don't resolve t… #24009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
bug
aws-cdk-automation
requested changes
Feb 4, 2023
I don't think this one needs integration tests, because this isn't a deployed construct. |
…emplates Templates are placed inside a path described by their closest assembly. Using this assembly lets nested stack templates resolve, regardless of their stage depth. I took the opportunity to reduce the scope of synth to only the containing template, regardless of the stack being nested or not. This should decrease load on user machines when synthesizing templates for apps with multiple stages. Closes aws#24004.
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…emplates
Templates are placed inside a path described by their closest assembly. Using this assembly lets nested stack templates resolve, regardless of their stage depth. Previously, they would fail to resolve if they were in a stage other than the app.
I took the opportunity to reduce the scope of synth to only the containing template, regardless of the stack being nested or not. This should decrease load on user machines when synthesizing templates for apps with multiple stages.
Closes #24004.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license