Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ec2): tokenised subnet.subnetId filtered by the SubnetIdSubnetFilter returns an empty array #24625

Merged
merged 10 commits into from
Mar 29, 2023
Merged

fix(ec2): tokenised subnet.subnetId filtered by the SubnetIdSubnetFilter returns an empty array #24625

merged 10 commits into from
Mar 29, 2023

Conversation

ahmetsoykan
Copy link
Contributor

Fix for SubnetFilter.byId()

fix for returning an empty array after this SubnetFilter.byId() applied

Closes #24427.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 14, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 14, 2023 23:28
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@ahmetsoykan ahmetsoykan changed the title 24427 fix(aws-ec2): allow tokenised subnet.subnetId filtered correctly by the SubnetIdSubnetFilter, which was resulting as an empty [] Mar 14, 2023
@ahmetsoykan ahmetsoykan changed the title fix(aws-ec2): allow tokenised subnet.subnetId filtered correctly by the SubnetIdSubnetFilter, which was resulting as an empty [] fix(ec2): allow tokenised subnet.subnetId filtered correctly by the SubnetIdSubnetFilter, which was resulting as an empty [] Mar 14, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 16, 2023 20:52

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(ec2): allow tokenised subnet.subnetId filtered correctly by the SubnetIdSubnetFilter, which was resulting as an empty [] fix(ec2): tokenised subnet.subnetId filtered by the SubnetIdSubnetFilter returns an empty array Mar 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1e658ea
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d0912ca into aws:main Mar 29, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@sbidy sbidy mentioned this pull request Jul 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

@aws-cdk-automation aws-cdk-automation Awaiting requested review from aws-cdk-automation

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-ec2: SubnetFilter byIds does not work as expected when using vpc.selectSubnets()
3 participants
@ahmetsoykan @aws-cdk-automation @TheRealAmazonKendra