Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(batch): new L2 Constructs #24775
feat(batch): new L2 Constructs #24775
Changes from 40 commits
42bf0b8
6e31c93
cd3a344
9b936ab
bf696de
c76fdc1
b1481c4
8e3c927
fadbcaa
2a2aabd
cf742a1
6adf6c1
a63c62b
7bf967e
6b8c386
1ebcb82
9ffb2b6
63798aa
ef0ce0b
c03407f
e41fae6
c097ac2
2ed534c
144b193
d4aade0
6c60622
27b9363
0237fde
cb3497e
88874da
b1c45c3
62ca79c
95f9e5b
4e70e64
f7e038b
4488f38
07b6132
8f89a26
a9ba303
e54a4bd
784b605
f92e99f
15a5b4c
8699f30
9c561a0
fec0757
6babcca
89554cb
5e037db
fa08646
3b2f98d
252fb82
92f8370
6549484
1547bd2
fda4412
1ca2f70
8722424
71003c6
83139a4
039cd40
a4ff001
18b7d54
a2554cf
5b173ca
f5fb0f1
6f741f9
bb2e023
a9455bb
b9584d1
e666e5d
52cf5ef
42848ef
6ddef3d
34b5ba5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the worst behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ComputeEnvironment will scale down to
minvCpus
whenDISABLED
and running jobs complete on existing instances above min.The Batch docs read
aka up.
If user want a non-zero
minvCpus
ComputeEnvironment to scale to zero for their use-case, setminvCpus = 0
when setting state toDISABLED
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this property exposed? What do we do for
ComputeEnvironment.fromComputeEnvironmentArn()
etc?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We set it to
true
and give empty values where needed:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, but who needs it? What other construct cannot operate without this exposed?
Because it seems to be designed for use by subclasses, but the subclass initialization is awkward currently.