-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use interface references in public api (awslint:ref-via-interface) #2499
Merged
Commits on May 8, 2019
-
refactor: use interface references in public api (awslint:ref-via-int…
…erface) Adds a new awslint:ref-via-interface rule which validates that all input APIs (e.g. props, method arguments) use construct interface (IBucket) and not concrete classes (Bucket). This is in order to enable passing in unowned resources and in accordance with the aws construct library guidelines. There are situations where an owned resource is required. In those, the rule can be disabled by adding [disable-awslint:ref-via-interface] to the element's inline documentation. To enable this, the following new construct interfaces were added, along with `fromXxx` import methods: * `applicationautoscaling.IScalableTarget` * `cloudwatch.IAlarm` * `ecs.IService` * `ecs.IEc2Service` * `ec2.IFargateService` * `ecs.ITaskDefinition` * `iam.IGroup` * `iam.IUser` * `iam.IPolicy` * `lambda.IVersion` BREAKING CHANGE: `apigateway.ResourceBase.trackChild` is now internal. * `cloudfront.S3OriginConfig.originAccessIdentity` is now `originAccessIdentityId` * `codedeploy.LambdaDeploymentGroup.alarms` is now `cloudwatch.IAlarm[]` (previously `cloudwatch.Alarm[]`) * `codepipeline.crossRegionScaffoldingStacks` renamed to `crossRegionScaffolding` * `codepipeline.CrossRegionScaffoldingStack` renamed to `codepipeline.CrossRegionScaffolding` and cannot be instantiated (abstract) * `ec2.VpcSubnet.addDefaultRouteToNAT` renamed to `addDefaultNatRoute` and made public * `ec2.VpcSubnet.addDefaultRouteToIGW` renamed to `addDefaultInternetRoute`, made public and first argument is the gateway ID (string) and not the CFN L1 class * `ecs.Ec2EventRuleTarget.taskDefinition` is now `ITaskDefinition` (previously `TaskDefinition`) * `lambda.IEventSource.bind` now accepts `IFunction` instead of `FunctionBase`. Use `IFunction.addEventSourceMapping` to add an event source mapping under the function. * `lambda.Layer.grantUsage` renamed to `lambda.layer.addPermission` and returns void * `stepfunctions.StateMachine.role` is now `iam.IRole` (previously `iam.Role`)
Elad Ben-Israel committedMay 8, 2019 Configuration menu - View commit details
-
Copy full SHA for 1ff8a42 - Browse repository at this point
Copy the full SHA 1ff8a42View commit details -
Elad Ben-Israel committed
May 8, 2019 Configuration menu - View commit details
-
Copy full SHA for ee06ce0 - Browse repository at this point
Copy the full SHA ee06ce0View commit details -
Elad Ben-Israel committed
May 8, 2019 Configuration menu - View commit details
-
Copy full SHA for a7b0d9e - Browse repository at this point
Copy the full SHA a7b0d9eView commit details -
* add VpcSubnet.isVpcSubnet * Do not use arbitrary duck-typing in EKS
Elad Ben-Israel committedMay 8, 2019 Configuration menu - View commit details
-
Copy full SHA for 5f72275 - Browse repository at this point
Copy the full SHA 5f72275View commit details -
Elad Ben-Israel committed
May 8, 2019 Configuration menu - View commit details
-
Copy full SHA for a1d7a7b - Browse repository at this point
Copy the full SHA a1d7a7bView commit details -
Elad Ben-Israel committed
May 8, 2019 Configuration menu - View commit details
-
Copy full SHA for 1edb61e - Browse repository at this point
Copy the full SHA 1edb61eView commit details -
validate explicit stack name instead of construct id
Elad Ben-Israel committedMay 8, 2019 Configuration menu - View commit details
-
Copy full SHA for 549bf24 - Browse repository at this point
Copy the full SHA 549bf24View commit details -
Elad Ben-Israel committed
May 8, 2019 Configuration menu - View commit details
-
Copy full SHA for 06ad626 - Browse repository at this point
Copy the full SHA 06ad626View commit details -
Merge remote-tracking branch 'origin/master' into benisrae/ref-via-in…
…terface
Elad Ben-Israel committedMay 8, 2019 Configuration menu - View commit details
-
Copy full SHA for 7603d26 - Browse repository at this point
Copy the full SHA 7603d26View commit details -
Elad Ben-Israel committed
May 8, 2019 Configuration menu - View commit details
-
Copy full SHA for c339fca - Browse repository at this point
Copy the full SHA c339fcaView commit details -
Elad Ben-Israel committed
May 8, 2019 Configuration menu - View commit details
-
Copy full SHA for c4b1486 - Browse repository at this point
Copy the full SHA c4b1486View commit details -
Elad Ben-Israel committed
May 8, 2019 Configuration menu - View commit details
-
Copy full SHA for 9c767c1 - Browse repository at this point
Copy the full SHA 9c767c1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.