Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli-lib): add missing deploy options #25042

Merged
merged 23 commits into from
Apr 18, 2023
Merged

feat(cli-lib): add missing deploy options #25042

merged 23 commits into from
Apr 18, 2023

Conversation

abelmokadem
Copy link
Contributor

Add missing deploy options to the cdk cli lib.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Apr 12, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team April 12, 2023 07:27
@abelmokadem abelmokadem mentioned this pull request Apr 13, 2023
Closed
2 tasks
mrgrain
mrgrain approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

@mrgrain mrgrain changed the title chore(cli-lib): Add missing deploy options feat(cli-lib): Add missing deploy options Apr 17, 2023
@mrgrain mrgrain changed the title feat(cli-lib): Add missing deploy options feat(cli-lib): add missing deploy options Apr 17, 2023
@mrgrain mrgrain added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes effort/small Small work item – less than a day of effort and removed pr-linter/exempt-test The PR linter will not require test changes labels Apr 17, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

mrgrain
mrgrain previously requested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@mrgrain mrgrain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just add a test for the additional options to commands.test.ts please and also add a test can parse number arguments similar to the existing ones. Thanks a lot!

@aws-cdk-automation aws-cdk-automation dismissed their stale review April 17, 2023 19:37

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify mergify bot dismissed mrgrain’s stale review April 17, 2023 19:55

Pull request has been modified.

Ash Belmokadem added 2 commits April 17, 2023 22:16
@abelmokadem
Copy link
Contributor Author

Done

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 55f9773
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mrgrain
mrgrain approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mergify
Copy link
Contributor

mergify bot commented Apr 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ac40aed into aws:main Apr 18, 2023
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abelmokadem @aws-cdk-automation @mrgrain