fix(batch): JobDefinition's ContainerDefinition's Image is synthesized with [Object object]
#25466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
Tokenization.resolve()
, which uses a generic token resolver that does${token1}${token2}
instead of creating anFn::Split
object. The only reason that token existed was to mutate the L1 object after synthesis so subclasses could fill in theexecutionRole
. TheexecutionRole
was meant to be optional for EC2 jobs and required for Fargate jobs. Setting theloggingConfig
being defined would force it to be defined it for EC2 Jobs. However, theloggingConfig
was always defined, because it was set to aLazy
(which could result inundefined
, but that doesn't matter: it was defined during synthesis). So theexecutionRole
was always being set:This PR makes it clear that the
executionRole
is created by default.Closes #25250
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license