-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(synthetics): support runtime nodejs puppeteer 4.0 #25553
Merged
mergify
merged 6 commits into
aws:main
from
WinterYukky:feat/synthetics/support-runtime-puppeteer-4.0
May 30, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0e5b041
feat(synthetics): support runtime puppeteer 4.0
WinterYukky 0c287c5
Merge branch 'main' of https://github.com/WinterYukky/aws-cdk into fe…
WinterYukky a9b2a2f
Merge branch 'main' into feat/synthetics/support-runtime-puppeteer-4.0
WinterYukky 85dfccf
test(synthetics): partial revert integ tests
WinterYukky 4107bf1
chore(synthetics): fix indent and format
WinterYukky 52bc28b
Merge branch 'main' into feat/synthetics/support-runtime-puppeteer-4.0
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 3 additions & 4 deletions
7
packages/@aws-cdk/aws-synthetics-alpha/test/canaries/nodejs/node_modules/canary.js
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
# This example comes from the AWS Synthetics service console "API canary" blueprint | ||
|
||
import os | ||
import json | ||
import http.client | ||
import urllib.parse | ||
|
@@ -23,7 +24,7 @@ def verify_request(method, url, post_data=None, headers={}): | |
else: | ||
conn = http.client.HTTPConnection(parsed_url.hostname, parsed_url.port) | ||
|
||
conn.request(method, url, str(post_data), headers) | ||
conn.request(method, url, post_data, headers) | ||
response = conn.getresponse() | ||
logger.info("Status Code: %s " % response.status) | ||
logger.info("Response Headers: %s" % json.dumps(response.headers.as_string())) | ||
|
@@ -46,7 +47,7 @@ def verify_request(method, url, post_data=None, headers={}): | |
|
||
def main(): | ||
|
||
url = 'https://example.com/' | ||
url = os.environ['URL'] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed this dummy url to actual URL that created in integ test stack. |
||
method = 'GET' | ||
postData = "" | ||
headers = {} | ||
|
32 changes: 32 additions & 0 deletions
32
.../test/integ.canary.js.snapshot/IntegCanaryTestDefaultTestDeployAssert3AD5A094.assets.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
{ | ||
"version": "31.0.0", | ||
"files": { | ||
"36618132bd37b6b15f9987b57ad1fbf613f1ad937aec72381232b163ed9c44c4": { | ||
"source": { | ||
"path": "asset.36618132bd37b6b15f9987b57ad1fbf613f1ad937aec72381232b163ed9c44c4.bundle", | ||
"packaging": "zip" | ||
}, | ||
"destinations": { | ||
"current_account-current_region": { | ||
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}", | ||
"objectKey": "36618132bd37b6b15f9987b57ad1fbf613f1ad937aec72381232b163ed9c44c4.zip", | ||
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}" | ||
} | ||
} | ||
}, | ||
"0d889e0d833f8b9b09eff9583a832802952f1f7f181507ea7cec6916c2721470": { | ||
"source": { | ||
"path": "IntegCanaryTestDefaultTestDeployAssert3AD5A094.template.json", | ||
"packaging": "file" | ||
}, | ||
"destinations": { | ||
"current_account-current_region": { | ||
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}", | ||
"objectKey": "0d889e0d833f8b9b09eff9583a832802952f1f7f181507ea7cec6916c2721470.json", | ||
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}" | ||
} | ||
} | ||
} | ||
}, | ||
"dockerImages": {} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This blueprint was renewed in AWS Synthetics service console and failed run, so I replaced this script to latest script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here