Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-lambda): proper handling of custom runtimes with layers #2566

Closed
wants to merge 1 commit into from
Closed

fix(aws-lambda): proper handling of custom runtimes with layers #2566

wants to merge 1 commit into from

Conversation

coderbyheart
Copy link
Contributor

This compares layer and function runtime by name.

In case we construct a lambda and a layer with new Runtime(...) the check will fail because it compares two different object instances

 
    const baseLayer = new LayerVersion(this, 'layer', {
            compatibleRuntimes: [new Runtime('nodejs10.x')],
        });

    const l = new Function(this, 'lambda', {
            runtime: new Runtime('nodejs10.x'),
            layers: [baseLayer],
        });

Since this is not changing any features / behavior I don't think we need to update tests.

✔️ By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Compare layer and function runtime by name.
@coderbyheart coderbyheart requested a review from a team as a code owner May 16, 2019 13:47
@spg
Copy link
Contributor

spg commented May 17, 2019

Hey! I've already opened a pull request that kind of addresses the same concerns: #2543

@rix0rrr
Copy link
Contributor

rix0rrr commented May 20, 2019

Just merged the other one, so I will be closing this. Thanks for the contribution though!

@rix0rrr rix0rrr closed this May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants