Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove "export"s and normalize resource names #2580

Merged
merged 39 commits into from
May 18, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
codebuild
Elad Ben-Israel committed May 17, 2019
commit 4d2ccd46de657ff368f814828e91138823a926c6
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-codebuild/lib/project.ts
Original file line number Diff line number Diff line change
@@ -395,7 +395,7 @@ export interface CommonProjectProps {
* Encryption key to use to read and write artifacts
* If not specified, a role will be created.
*/
readonly encryptionKey?: kms.IEncryptionKey;
readonly encryptionKey?: kms.IKey;

/**
* Bucket to store cached source artifacts
@@ -442,7 +442,7 @@ export interface CommonProjectProps {
*
* Specify this if the codebuild project needs to access resources in a VPC.
*/
readonly vpc?: ec2.IVpcNetwork;
readonly vpc?: ec2.IVpc;

/**
* Where to place the network interfaces within the VPC.
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-codebuild/test/integ.project-vpc.ts
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ import { Project } from '../lib';
const app = new cdk.App();

const stack = new cdk.Stack(app, 'aws-cdk-codebuild-project-vpc');
const vpc = new ec2.VpcNetwork(stack, 'MyVPC', {
const vpc = new ec2.Vpc(stack, 'MyVPC', {
maxAZs: 1,
natGateways: 1,
});
6 changes: 3 additions & 3 deletions packages/@aws-cdk/aws-codebuild/test/test.codebuild.ts
Original file line number Diff line number Diff line change
@@ -626,7 +626,7 @@ export = {
const stack = new cdk.Stack();

const bucket = new s3.Bucket(stack, 'MyBucket');
const vpc = new ec2.VpcNetwork(stack, 'MyVPC');
const vpc = new ec2.Vpc(stack, 'MyVPC');
const securityGroup = new ec2.SecurityGroup(stack, 'SecurityGroup1', {
groupName: 'Bob',
vpc,
@@ -673,7 +673,7 @@ export = {
const stack = new cdk.Stack();

const bucket = new s3.Bucket(stack, 'MyBucket');
const vpc = new ec2.VpcNetwork(stack, 'MyVPC');
const vpc = new ec2.Vpc(stack, 'MyVPC');
const securityGroup = new ec2.SecurityGroup(stack, 'SecurityGroup1', {
groupName: 'Bob',
vpc,
@@ -695,7 +695,7 @@ export = {
'with VPC configuration but allowAllOutbound identified'(test: Test) {
const stack = new cdk.Stack();
const bucket = new s3.Bucket(stack, 'MyBucket');
const vpc = new ec2.VpcNetwork(stack, 'MyVPC');
const vpc = new ec2.Vpc(stack, 'MyVPC');
const securityGroup = new ec2.SecurityGroup(stack, 'SecurityGroup1', {
groupName: 'Bob',
vpc,