-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codebuild): Support for CodeBuild Image aws/codebuild/amazonlinux2-x86_64-standard:5.0
#26058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request This is just adding a value to an enum which doesn't change any pre-existing behaviour |
aws/codebuild/amazonlinux2-x86_64-standard:5.0
aws/codebuild/amazonlinux2-x86_64-standard:5.0
aws/codebuild/amazonlinux2-x86_64-standard:5.0
The document says |
I did consider this actually, but ultimately went with the Image Identifier as:
Maybe this should be revised by the codebuild team or we can just include both. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, this looks good to me.
Tagging @corymhall to get a second opinion for the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I synced with Cory and have some feedback. Let me know if you need any clarifications.
...s-cdk-testing/framework-integ/test/aws-codebuild/test/integ.project-amazonlinux-image.lit.ts
Outdated
Show resolved
Hide resolved
...s-cdk-testing/framework-integ/test/aws-codebuild/test/integ.project-amazonlinux-image.lit.ts
Outdated
Show resolved
Hide resolved
Pull request has been modified.
@vinayak-kukreja Thanks for the comments, I've fixed it up and the new commit passed the CI tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you for addressing the feedback. Just some minor comments.
constructor(scope: Construct, id: string) { | ||
super(scope, id); | ||
|
||
/// !show |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, could you also remove: /// !show
and /// !hide
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed this too 😄
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your contribution :)
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Added support for Amazon Linux 2023 CodeBuild Image:
https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html
aws/codebuild/amazonlinux2-x86_64-standard:5.0
i.e you can now reference the latest codebuild image via the
codebuild.LinuxBuildImage.AMAZON_LINUX_2_5
enum rather than having to resolve it manually likeLinuxBuildImage.codeBuildImage('aws/codebuild/amazonlinux2-x86_64-standard:5.0')
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license