Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: update all 'onXxx' methods to be CloudWatch Events (#2609)" #2620

Closed
wants to merge 1 commit into from

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented May 23, 2019

This reverts commit 28942d2.

This is reverting the changes made in this PR, because Elad would prefer a different API, and since we want to release tomorrow I'd rather prefer we only have one breaking change rather than two.


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@rix0rrr rix0rrr requested review from RomainMuller, skinny85, SoManyHs and a team as code owners May 23, 2019 16:13
@rix0rrr
Copy link
Contributor Author

rix0rrr commented May 24, 2019

Not sure I want to revert this anymore. Discussion at: #2609 (comment)

@brad-jones
Copy link

How tied together are the different CDK packages?

Can one run v0.32 of everything and stay with v0.31 of cloudwatch-events?

Just curious.

@rix0rrr
Copy link
Contributor Author

rix0rrr commented May 24, 2019

Can one run v0.32 of everything and stay with v0.31 of cloudwatch-events?

No, everything has to be the same version.

@rix0rrr rix0rrr closed this May 24, 2019
@rix0rrr rix0rrr deleted the huijbers/revert-on-xxx-methods branch June 17, 2019 07:43
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants