Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sns-subscriptions): cannot add Lambda Subscription when using a Lambda Construct from a different Construct Library #26206

Merged
merged 2 commits into from
Jul 3, 2023
Merged

fix(sns-subscriptions): cannot add Lambda Subscription when using a Lambda Construct from a different Construct Library #26206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48f32dd
fix: fix construct check
mjeanroy Jul 3, 2023
8b50b6a
Merge branch 'main' into fix/fix-is-construct-check
mrgrain Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-sns-subscriptions/lib/lambda.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class LambdaSubscription implements sns.ITopicSubscription {
public bind(topic: sns.ITopic): sns.TopicSubscriptionConfig {
// Create subscription under *consuming* construct to make sure it ends up
// in the correct stack in cases of cross-stack subscriptions.
if (!(this.fn instanceof Construct)) {
if (!Construct.isConstruct(this.fn)) {
throw new Error('The supplied lambda Function object must be an instance of Construct');
}

Expand Down