Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert "docs(cloudwatch): document cross-account/cross-region alarm limitations" #26246

Merged
merged 2 commits into from
Jul 6, 2023
Merged

chore: revert "docs(cloudwatch): document cross-account/cross-region alarm limitations" #26246

merged 2 commits into from
Jul 6, 2023

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Jul 5, 2023

Reverts #26204

The documentation that cross-account alarms with evaluationPeriods > 1 is incorrect, or at least too strict. I was able to create an alarm in Account B that references a metric in Account A with evaluationPeriod = 2.

@kaizencc kaizencc marked this pull request as ready for review July 5, 2023 18:59
@gitpod-io
Copy link

gitpod-io bot commented Jul 5, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team July 5, 2023 19:00
@github-actions github-actions bot added the p2 label Jul 5, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 5, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 5, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2a521c1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 212b81b into main Jul 6, 2023
@mergify mergify bot deleted the revert-26204-huijbers/document-alarm-limitations branch July 6, 2023 17:57
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

tmokmss pushed a commit to tmokmss/aws-cdk that referenced this pull request Jul 9, 2023
@kaizencc @tmokmss
chore: revert "docs(cloudwatch): document cross-account/cross-region …
9247a59 
…alarm limitations" (aws#26246)

Reverts aws#26204

The documentation that cross-account alarms with `evaluationPeriods > 1` is incorrect, or at least too strict. I was able to create an alarm in Account B that references a metric in Account A with evaluationPeriod = 2.
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@kaizencc @bmoffatt
chore: revert "docs(cloudwatch): document cross-account/cross-region …
4eacc1b 
…alarm limitations" (aws#26246)

Reverts aws#26204

The documentation that cross-account alarms with `evaluationPeriods > 1` is incorrect, or at least too strict. I was able to create an alarm in Account B that references a metric in Account A with evaluationPeriod = 2.
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaizencc @aws-cdk-automation @mrgrain