Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apigateway): method response from rest api default options are not passed to Method #26275

Merged
merged 3 commits into from
Jul 7, 2023
Merged

fix(apigateway): method response from rest api default options are not passed to Method #26275

merged 3 commits into from
Jul 7, 2023

Conversation

lpizzinidev
Copy link
Contributor

methodResponses specified in RestApi's defaultMethodOptions were not passed to Method as default.
This fix solves the problem.

Closes #26252.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 7, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team July 7, 2023 07:33
@github-actions github-actions bot added admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Jul 7, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain mrgrain added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jul 7, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 7, 2023 11:29

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 7, 2023
mrgrain
mrgrain previously approved these changes Jul 7, 2023
View reviewed changes
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed mrgrain’s stale review July 7, 2023 11:50

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1c28672
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9bcc6d5 into aws:main Jul 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

tmokmss pushed a commit to tmokmss/aws-cdk that referenced this pull request Jul 9, 2023
@lpizzinidev @tmokmss
fix(apigateway): method response from rest api default options are no…
6ff3a0a 
…t passed to Method (aws#26275)

`methodResponses` specified in `RestApi`'s `defaultMethodOptions` were not passed to `Method` as default.
This fix solves the problem.

Closes aws#26252.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@mrgrain
Copy link
Contributor

mrgrain commented Jul 11, 2023

Hey @lpizzinidev Are you on cdk.dev by any chance? What's the best way to contact you?

@lpizzinidev
Copy link
Contributor Author

lpizzinidev commented Jul 12, 2023 •
edited
Loading

Hi @mrgrain ✋
I'm not on cdk.dev (I don't use Slack very much outside of my job).
You can send me an e-mail at lpizzini7@gmail.com

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@lpizzinidev @bmoffatt
fix(apigateway): method response from rest api default options are no…
162ac04 
…t passed to Method (aws#26275)

`methodResponses` specified in `RestApi`'s `defaultMethodOptions` were not passed to `Method` as default.
This fix solves the problem.

Closes aws#26252.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_apigateway: Method responses from default method options set on RestApi not passed to Methods
3 participants
@lpizzinidev @aws-cdk-automation @mrgrain