Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): make cdk docs open the new API reference #2633

Merged
merged 1 commit into from
May 24, 2019
Merged

fix(cli): make cdk docs open the new API reference #2633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/aws-cdk/lib/commands/docs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ export function handler(args: yargs.Arguments) {
}

export async function realHandler(options: CommandOptions): Promise<number> {
const docVersion = require('../../package.json').version;
const url = `https://awslabs.github.io/aws-cdk/versions/${docVersion}/`;
const url = `https://docs.aws.amazon.com/cdk/api/latest/`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not the correct version? (or do we still don't have that, in which case open an issue so we don't forget).

print(colors.green(url));
const browserCommand = (options.args.browser as string).replace(/%u/g, url);
debug(`Opening documentation ${colors.green(browserCommand)}`);
Expand Down