fix(pkglint): library creation generates incorrect package names #26330
Conversation
|
|
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
kaizencc
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Turning rosetta back on again. Was turned off in April in #26330 and never turned on again. Therefore we have a significant diff of uncompilable examples. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Turning rosetta back on again. Was turned off in April in #26330 and never turned on again. Therefore we have a significant diff of uncompilable examples. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#26330) Fairly certain that `options.packageName` is only used in the README example generation so there should be no other side-effects. The reason why this wasn't caught earlier is because we turned `rosetta:strict` off. I am working on a separate PR to fix those issues. These are not the only modules with faulty examples. The rest will be fixed in aws#26331 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Turning rosetta back on again. Was turned off in April in aws#26330 and never turned on again. Therefore we have a significant diff of uncompilable examples. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fairly certain that
options.packageNameis only used in the README example generation so there should be no other side-effects.The reason why this wasn't caught earlier is because we turned
rosetta:strictoff. I am working on a separate PR to fix those issues. These are not the only modules with faulty examples. The rest will be fixed in #26331By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license