-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): Equal sign not included in Tag Value #26374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Hey @seungholee-dev Pretty sure something went wrong with this PR... A lot of changes. I'll close this one for now and you can try again with a new one, okay? |
Description
If you need a tag with a key value pair such as
Key : MyKey
Value : MyValue=Something
The stack will have a key value pair that shows
Key: MyKey
Value: MyValue
Expected Result
I would expect the value of the tag to be MyValue=Something
Closes #21003
I also wrote integration test for cli. As I am a new contributor to this project, I would love the review of the changes and code.
Thanks!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license