Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): unclear docs on valid ec2 task definition placement constraints and no validation of input #25933 #26384

Merged
merged 26 commits into from
Aug 2, 2023

Merge branch 'main' into fix/25905-ecs-placement-constraints

f480d7b
Select commit
Loading
Failed to load commit list.
Merged

fix(ecs): unclear docs on valid ec2 task definition placement constraints and no validation of input #25933 #26384

Merge branch 'main' into fix/25905-ecs-placement-constraints
f480d7b
Select commit
Loading
Failed to load commit list.
Mergify / Queue: Embarked in merge train succeeded Aug 2, 2023 in 0s

The pull request embarked with main (5f29295) is mergeable

Required conditions for merge:

  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • status-success~=AWS CodeBuild us-east-1
  • all of [📃 From pull request rule automatic merge]:
    • #approved-reviews-by>=1
    • #changes-requested-reviews-by=0
    • -approved-reviews-by~=author
    • -closed
    • -draft [:pushpin: queue requirement]
    • -label~=(blocked|do-not-merge|no-squash|two-approvers)
    • -merged
    • -mergify-configuration-changed [:pushpin: queue -> allow_merging_configuration_change setting requirement]
    • -title~=(WIP|wip)
    • author!=dependabot-preview[bot]
    • author!=dependabot[bot]
    • base!=release
    • status-success=validate-pr
    • status-success~=AWS CodeBuild us-east-1
    • any of [:twisted_rightwards_arrows: queue conditions]:
      • all of [:pushpin: queue conditions of queue default]:
        • #approved-reviews-by>=1 [🛡 GitHub branch protection]
        • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
        • any of [🛡 GitHub branch protection]:
          • check-success=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
          • check-neutral=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
          • check-skipped=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
  • any of [🛡 GitHub branch protection]:
    • check-success=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-neutral=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-skipped=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)

Check-runs and statuses of the embarked pull request #26384:

auto-approvedetails
submit-to-test-pipelinedetails
AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)Build succeeded for project AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQvdetails
cli-changesdetails
download-if-workflow-rundetails
validate-prdetails