-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tool): Run projen for node-bundle #26468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @matt9ucci Thanks for this PR! I see why you did this. But I'd actually rather have projen removed from this package. Doesn't really make sense to mix the tooling here. LMK if you want to take this, otherwise feel free to close the PR.
@mrgrain Thank you for your reply. I will close the PR. I was trying to build
It is due to the old version of projen. If projen is removed, the error is removed too. That's okay. |
We don't have a mechanism to keep a projen project up to date. It's better if all packages in a monorepo use the same tooling. Replaces #26468 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
We don't have a mechanism to keep a projen project up to date. It's better if all packages in a monorepo use the same tooling. Replaces aws#26468 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Run projen for node-bundle
Execute
npx lerna run projen --scope=@aws-cdk/node-bundle
and commit the updated files.The updates include:
@types/node
from 14 to 16By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license