Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fic(ecs): fix fromClusterAttributes #2649

Merged
merged 2 commits into from
May 28, 2019
Merged

fic(ecs): fix fromClusterAttributes #2649

merged 2 commits into from
May 28, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented May 27, 2019

Remove unnecessary import.

Fixes #2631.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

fic(ecs): fix fromClusterAttributes
e7543a7 
Remove unnecessary import.

Fixes #2631.
@rix0rrr rix0rrr requested review from SoManyHs and a team as code owners May 27, 2019 14:24
eladb
eladb reviewed May 28, 2019
View reviewed changes
packages/@aws-cdk/aws-ecs/lib/cluster.ts
@@ -394,7 +394,7 @@ class ImportedCluster extends Construct implements ICluster {
constructor(scope: Construct, id: string, props: ClusterAttributes) {
super(scope, id);
this.clusterName = props.clusterName;
this.vpc = ec2.Vpc.fromVpcAttributes(this, "vpc", props.vpc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did fromVpcAttributes accept IVpc? Structural typing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

@eladb
Copy link
Contributor

eladb commented May 28, 2019

Test?

@rix0rrr rix0rrr merged commit f4817b1 into master May 28, 2019
@rix0rrr rix0rrr deleted the huijbers/ecs-cluster branch May 28, 2019 14:35
@rix0rrr rix0rrr mentioned this pull request Jun 4, 2019
Closed
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
3 participants
@rix0rrr @eladb @NGL321