Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamodb): global table L2 #26563

Merged
merged 120 commits into from
Aug 29, 2023
Merged

feat(dynamodb): global table L2 #26563

merged 120 commits into from
Aug 29, 2023

Conversation

colifran
Copy link
Contributor

@colifran colifran commented Jul 28, 2023

This PR is for the implementation of the GlobalTable L2.

Please reference the following RFC: https://github.com/aws/aws-cdk-rfcs/blob/master/text/0510-dynamodb-global-table.md

Closes #16118


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
…lobalTable

Signed-off-by: Francis <colifran@amazon.com>
…Index to base class

Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
…oned throughput settings

Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
…obal secondary indexes

Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
…itial logic for replica table configuration

Signed-off-by: Francis <colifran@amazon.com>
…ttributes

Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
…getters for each

Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 23, 2023
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Can you improve the structure of the README a bit while you're in here anyway?

Other than that, I think we can ship it.

packages/aws-cdk-lib/aws-dynamodb/README.md Show resolved Hide resolved
packages/aws-cdk-lib/aws-dynamodb/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-dynamodb/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-dynamodb/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-dynamodb/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-dynamodb/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-dynamodb/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-dynamodb/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-dynamodb/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-dynamodb/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just got a minor thing on the ADR.

packages/aws-cdk-lib/aws-dynamodb/adr/index.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-dynamodb/adr/index.md Outdated Show resolved Hide resolved
colifran and others added 3 commits August 25, 2023 07:44
…s on stream view type

Signed-off-by: Francis <colifran@amazon.com>
@mrgrain mrgrain dismissed their stale review August 25, 2023 15:00

requested changes have been made

Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Aug 29, 2023
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the tiiiiniest note, and after that merge at your own leisure!

packages/aws-cdk-lib/aws-dynamodb/README.md Outdated Show resolved Hide resolved
colifran and others added 2 commits August 29, 2023 06:45
Signed-off-by: Francis <colifran@amazon.com>
@colifran colifran removed the pr/do-not-merge This PR should not be merged at this time. label Aug 29, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5264ab7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 49dab34 into main Aug 29, 2023
8 checks passed
@mergify mergify bot deleted the colifran/global-table branch August 29, 2023 16:15
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

colifran added a commit that referenced this pull request Aug 31, 2023
mergify bot pushed a commit that referenced this pull request Sep 1, 2023
mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-dynamodb): L2 Construct for GlobalTable
4 participants