-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removes the requirement to have a domain name when using SSL certificates #26605
fix: removes the requirement to have a domain name when using SSL certificates #26605
Conversation
…ing a certificate to a Distribution, this means you can provision a new Distribution and then use associate-alias to transfer a domain name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Exemption Request This PR is rolling back a previous change rather than implementing new functionality, it doesn't seem to meet the criteria in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nsmith-amplience, before we can look at this PR the build needs to succeed. The current issue is:
aws-cdk-lib: aws-cloudfront/test/distribution.test.ts:514:1 - error TS1128: Declaration or statement expected.
aws-cdk-lib: 514 });
aws-cdk-lib: ~
aws-cdk-lib: aws-cloudfront/test/distribution.test.ts:514:2 - error TS1128: Declaration or statement expected.
aws-cdk-lib: 514 });
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
This PR allows for domain names to be optional when creating a Cloudfront Distribution that has a certificate attached to it. As Cloudfront Distributions allow for domains to be transferred with the
associate-alias
command there are scenarios where having an SSL certificate attached without a domain are valid, and attaching the SSL certificate in the CDK creation phase minimises the amount of stack drift.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license