Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): container port ranges in port mappings #26692

Merged
merged 23 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
aa97179
Add support for container port ranges for ECS
ste93cry Jul 11, 2023
bbdea4b
Update the README
ste93cry Aug 9, 2023
21315e3
Fix unit tests and rework port mapping validation logic
ste93cry Aug 10, 2023
38d3a39
Fix wrong expectations in unit tests
ste93cry Aug 10, 2023
ea90bd8
Add integration test
ste93cry Aug 10, 2023
2251c5d
Update the README
ste93cry Aug 14, 2023
d64f317
Reword the error message and add missing unit test
ste93cry Aug 14, 2023
9e234ca
Add validation of string format for `containerPortRange` prop
ste93cry Aug 14, 2023
84f0755
Make `containerPort` `non-nullable` again and handle BC
ste93cry Aug 17, 2023
e0e9044
Improve the docblock for `containerPort` and `containerPortRange`
ste93cry Aug 17, 2023
2406904
Add test for case where `containerPortRange` value is not concrete
ste93cry Aug 17, 2023
078eec3
Fix rendering of L1 construct for port mapping
ste93cry Aug 17, 2023
b6ea1a4
Fix typehint typo in README
ste93cry Aug 18, 2023
77d073e
Inline class property to local scoped variable
ste93cry Aug 18, 2023
539f810
Use `test()` instead of `describe()` when possible
ste93cry Aug 18, 2023
c4e3278
Improve usage documentation for `containerPort` and `containerPortRange`
ste93cry Aug 18, 2023
24fb02f
Rename the `CONTAINER_PORT_UNSET_VALUE` and move it
ste93cry Aug 18, 2023
f5089a5
Update typo in README (again)
ste93cry Aug 18, 2023
236bb9f
Merge branch 'main' into add-container-port-range-support-for-ecs
rix0rrr Aug 18, 2023
5544967
Update aws-ecs-container-port-range.template.json
rix0rrr Aug 21, 2023
2b4aadd
Merge branch 'main' into add-container-port-range-support-for-ecs
rix0rrr Aug 22, 2023
895afcc
Merge branch 'main' into add-container-port-range-support-for-ecs
rix0rrr Aug 22, 2023
aa7cb6d
Merge branch 'main' into add-container-port-range-support-for-ecs
mergify[bot] Aug 22, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"version": "33.0.0",
"files": {
"21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22": {
"source": {
"path": "EcsContainerPortRangeDefaultTestDeployAssert87C0580C.template.json",
"packaging": "file"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22.json",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
}
},
"dockerImages": {}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
{
"Parameters": {
"BootstrapVersion": {
"Type": "AWS::SSM::Parameter::Value<String>",
"Default": "/cdk-bootstrap/hnb659fds/version",
"Description": "Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"
}
},
"Rules": {
"CheckBootstrapVersion": {
"Assertions": [
{
"Assert": {
"Fn::Not": [
{
"Fn::Contains": [
[
"1",
"2",
"3",
"4",
"5"
],
{
"Ref": "BootstrapVersion"
}
]
}
]
},
"AssertDescription": "CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."
}
]
}
}
}

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"version": "33.0.0",
"files": {
"ba598c1f1d84f7077ea9c16a6b921e4f8acf18e996100e72a8f17da980e64fdd": {
"source": {
"path": "asset.ba598c1f1d84f7077ea9c16a6b921e4f8acf18e996100e72a8f17da980e64fdd",
"packaging": "zip"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "ba598c1f1d84f7077ea9c16a6b921e4f8acf18e996100e72a8f17da980e64fdd.zip",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
},
"ed794a1018779c6037c9e21f6ee72baaab56db80b04c8227ef61e5edf5464fe4": {
"source": {
"path": "aws-ecs-container-port-range.template.json",
"packaging": "file"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "ed794a1018779c6037c9e21f6ee72baaab56db80b04c8227ef61e5edf5464fe4.json",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
}
},
"dockerImages": {}
}
Loading