Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-cdk-lib): ADOT Lambda Layer v0.32.0 #26793

Merged
merged 2 commits into from
Aug 17, 2023
Merged

feat(aws-cdk-lib): ADOT Lambda Layer v0.32.0 #26793

merged 2 commits into from
Aug 17, 2023

Conversation

vasireddy99
Copy link
Contributor

@vasireddy99 vasireddy99 commented Aug 17, 2023 •
edited
Loading

Add Latest ADOT Lambda Layer ARNs

Reference Links :

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Aug 17, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 17, 2023 18:01
aws-cdk-automation
aws-cdk-automation previously requested changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@vasireddy99 vasireddy99 changed the title feat(aws-cdk-lib): ADOT Lambda Layer v0.32.0 chore(aws-cdk-lib): ADOT Lambda Layer v0.32.0 Aug 17, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 17, 2023 18:47

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 17, 2023
@vasireddy99 vasireddy99 marked this pull request as draft August 17, 2023 19:44
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 17, 2023
@vasireddy99 vasireddy99 marked this pull request as ready for review August 17, 2023 21:35
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c5d982f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 17, 2023
@colifran colifran added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Aug 17, 2023
@colifran colifran changed the title chore(aws-cdk-lib): ADOT Lambda Layer v0.32.0 feat(aws-cdk-lib): ADOT Lambda Layer v0.32.0 Aug 17, 2023
colifran
colifran approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vasireddy99 Thanks for getting the new ARNs added!

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 89393a2 into aws:main Aug 17, 2023
33 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 17, 2023
@vasireddy99 vasireddy99 deleted the adotlambda branch August 18, 2023 05:03
@vasireddy99 vasireddy99 mentioned this pull request Aug 18, 2023
Merged
@vasireddy99
Copy link
Contributor Author

vasireddy99 commented Aug 18, 2023 •
edited
Loading

@vasireddy99 Thanks for getting the new ARNs added!

Thank you so much @colifran, Can you please help review this follow up PR #26801 to update constants and doc.

mergify bot pushed a commit that referenced this pull request Aug 24, 2023
@vasireddy99
fix(aws-cdk-lib): ADOT Lambda Layer constants update - v0.32.0 (#26801)
ad9d764 
Update constants/doc for ADOT Lambda Layer
Reference PR - #26793 


**NOTE**  This PR requires an update to an integration test and am unable
to run the `cdk-integ` tool to perform a real deployment

----

*By submitting this pull request, I confirm that I make my contribution under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colifran colifran colifran approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vasireddy99 @aws-cdk-automation @colifran