fix(ecr): AutoDeleteImages custom resource description contains "undefined"

[go-to-k]

The repository name is embedded in the description of CustomResourceProvider for the ECR AutoDeleteImages, but the repository name becomes to undefined because the CustomResourceProvider is created before the repository name is set.

  private enableAutoDeleteImages() {
    const firstTime = Stack.of(this).node.tryFindChild(`${AUTO_DELETE_IMAGES_RESOURCE_TYPE}CustomResourceProvider`) === undefined;
    const provider = CustomResourceProvider.getOrCreateProvider(this, AUTO_DELETE_IMAGES_RESOURCE_TYPE, {
      codeDirectory: path.join(__dirname, '..', '..', 'custom-resource-handlers', 'dist', 'aws-ecr', 'auto-delete-images-handler'),
      useCfnResponseWrapper: false,
      runtime: CustomResourceProviderRuntime.NODEJS_18_X,
      description: `Lambda function for auto-deleting images in ${this.repositoryName} repository.`,
    });

So I moved the enableAutoDeleteImages calls after following codes that set repositoryName in the Repository constructor.

this.repositoryName = this.getResourceNameAttribute(resource.ref);

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[tmokmss]

If we just move this assignment before calling enableAutoDeleteImages, will that resolve the problem?

aws-cdk/packages/aws-cdk-lib/aws-ecr/lib/repository.ts

Line 722 in bc86d05

this.repositoryName = this.getResourceNameAttribute(resource.ref);

[go-to-k]

@tmokmss

If we just move this assignment before calling enableAutoDeleteImages, will that resolve the problem?

In that case, ${this.repositoryName} is just Token[XX] instead of undefined, which may not make much sense.

I considered that as well, since it is more natural for the source code, but I did not change it out of respect for the intent of the original code.

[go-to-k]

@tmokmss

Sorry, I was misunderstood.

The getResourceNameAttribute uses mimicReference that produces a Lazy. So we should move the assignment before calling enableAutoDeleteImages.

I will change.

[tmokmss]

Thanks, LGTM. Make sure you change PR title and description as well :)

[go-to-k]

Thank you, I changed!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 23d4871
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).