-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(stepfunctions): multi-state example for map state #26870
Conversation
70e35d1
to
b4c62e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will help fix the build error. But you can also check locally with yarn rosetta --strict
.
When the build succeeds feel free to move this out of draft mode. Thanks for your contribution!
const definition = choice | ||
.when(condition1, step1) | ||
.otherwise(step2) | ||
.afterwards()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.afterwards()) | |
.afterwards() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @kaizencc for feedback.
I am running into JS heap out of memory
issue when I run yarn rosetta:extract --strict
on GitPod (hence having to publish to this draft PR after I make changes and note the build failures).
Are there any known workarounds? I tried increasing mem size using NODE_OPTIONS="--max-old-space-size=8192
but to no avail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also posted my query on cdk.dev slack for ref https://cdk-dev.slack.com/archives/C041656G340/p1692825834382109
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, but it is definitely a memory intensive process that may take more memory than yarn build
. Can you create an issue for it? That's probably the best thing to do here. Thanks for your contribution anyway!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kaizencc for approving, will do!
b4c62e9
to
1808212
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes #26707.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license