Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets-manager): SecretRotationApplication creates lambda on python 3.7 which is EOL #26884

Merged
merged 4 commits into from
Aug 25, 2023
Merged

fix(secrets-manager): SecretRotationApplication creates lambda on python 3.7 which is EOL #26884

merged 4 commits into from
Aug 25, 2023

Conversation

wilhen01
Copy link
Contributor

Update SecretRotationApplication versions to 1.1.367 - the latest available in the Serverless Application Repository. This will bump the deployed lambdas from Python 3.7 (which is EOL) to Python 3.9 (which is still within security support).

Closes #26866.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Aug 25, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 25, 2023 08:40
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Aug 25, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 25, 2023
@mrgrain mrgrain changed the title chore(secrets-manager): update rotation application versions to 1.1.367 fix(secrets-manager): update rotation application versions to 1.1.367 Aug 25, 2023
@mrgrain mrgrain changed the title fix(secrets-manager): update rotation application versions to 1.1.367 fix(secrets-manager): addRotationSingleUser() creates a lambda on python 3.7 which is EOL Aug 25, 2023
@mrgrain mrgrain changed the title fix(secrets-manager): addRotationSingleUser() creates a lambda on python 3.7 which is EOL fix(secrets-manager): SecretRotationApplication creates lambda on python 3.7 which is EOL Aug 25, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 25, 2023
@mrgrain mrgrain added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Aug 25, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 25, 2023 09:17

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 25, 2023
@mrgrain
Copy link
Contributor

mrgrain commented Aug 25, 2023

pr-linter/exempt-integ-test because snapshots have been updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b5f0820
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2d9d8d6 into aws:main Aug 25, 2023
9 checks passed
@wilhen01 wilhen01 deleted the secret-rotation-app-version-update branch August 25, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-rds): addRotationSingleUser() creates a lambda on python 3.7 which is EOL
3 participants