Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rds): cluster.instanceIdentifiers does not container writer instance ID #26929

Merged
merged 6 commits into from
Sep 19, 2023
Merged

fix(rds): cluster.instanceIdentifiers does not container writer instance ID #26929

merged 6 commits into from
Sep 19, 2023

Conversation

kirkwat
Copy link
Contributor

@kirkwat kirkwat commented Aug 30, 2023

Cluster writer instance ID is now returned in instanceIdentifiers with reader instance IDs.

Closes #25947.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Aug 30, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 30, 2023 02:52
aws-cdk-automation
aws-cdk-automation previously requested changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review August 30, 2023 03:56

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 30, 2023
jumic
jumic suggested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@jumic jumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have written a comment on the test case. Please add the proposed change there.

packages/aws-cdk-lib/aws-rds/test/cluster.test.ts Show resolved Hide resolved
@jumic
Copy link
Contributor

jumic commented Aug 30, 2023

Another hint: It is better to create a separate branch for each PR in your repo. If you create the PR from the main branch, you will have problems submitting multiple PRs.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Aug 30, 2023
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
rix0rrr
rix0rrr previously approved these changes Sep 6, 2023
View reviewed changes
@rix0rrr rix0rrr changed the title fix(rds): writer instance ID not returned with cluster instanceIdentifiers fix(rds): cluster.instanceIdentifiers does not container writer instance ID Sep 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed rix0rrr’s stale review September 6, 2023 19:40

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 6, 2023
@kirkwat kirkwat requested a review from rix0rrr September 11, 2023 15:40
mrgrain
mrgrain previously approved these changes Sep 19, 2023
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed mrgrain’s stale review September 19, 2023 10:06

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e7b7afb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d3789ab into aws:main Sep 19, 2023
8 checks passed
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

HBobertz pushed a commit that referenced this pull request Sep 19, 2023
@kirkwat
fix(rds): cluster.instanceIdentifiers does not container writer insta…
296acc9 
…nce ID (#26929)

Cluster writer instance ID is now returned in instanceIdentifiers with reader instance IDs.

Closes #25947.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumic jumic jumic approved these changes

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

@rix0rrr rix0rrr Awaiting requested review from rix0rrr

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RDS: DatabaseCluster Instance Identifiers Attribute
5 participants
@kirkwat @jumic @aws-cdk-automation @mrgrain @rix0rrr