Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stepfunction-tasks): allow string in outputLocation parameter #26968

Closed
wants to merge 5 commits into from

Conversation

razin99
Copy link
Contributor

@razin99 razin99 commented Sep 1, 2023

Issue currently faced

I tried to do the following:

new AthenaStartQueryExecution(
  stack,
  'Start Athena Query',
  {
    queryString: sfn.JsonPath.stringAt('$.queryString'),
    queryExecutionContext: {
      databaseName: 'database',
    },
    resultConfiguration: {
      encryptionConfiguration: {
        encryptionOption: EncryptionOption.S3_MANAGED,
      },
     outputLocation: {
        bucketName: 'query-results-bucket',
        objectKey: sfn.JsonPath.stringAt('$.folder'),
    },
  });

But was unable to due to an error message:

Field references must be the entire string, cannot concatenate them (found 's3://$[Token]/$[Token]')

Solution

Allow outputLocation to receive string. Then the new parameter can also be the following:

outputLocation: sfn.JsonPath.format(
  's3://query-results-bucket/folder/{}',
  sfn.JsonPath.format('$.folder'),
)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Sep 1, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 1, 2023 05:42
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@razin99 razin99 changed the title feat(aws-stepfunction-tasks): allow string in outputLocation parameter feat(stepfunction-tasks): allow string in outputLocation parameter Sep 1, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 1, 2023 07:18

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 89c2541
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 1, 2023
@@ -228,7 +238,7 @@ export interface ResultConfiguration {
*
* @default - Query Result Location set in Athena settings for this workgroup
*/
readonly outputLocation?: s3.Location;
readonly outputLocation?: s3.Location | string;
Copy link
Contributor

@mrgrain mrgrain Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately using a union type here will make any other language but typescript very unusable. They just turn into an any equivalent.

Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you have encountered an issue and I appreciate your drive to just go an fix it! In this case however, would you mind open an issue first? This gives our triage and support team a chance to have a look at it, possibly come with a workaround and at least inform the solution better.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 19, 2023
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants