-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stepfunction-tasks): allow string in outputLocation
parameter
#26968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
outputLocation
parameteroutputLocation
parameter
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@@ -228,7 +238,7 @@ export interface ResultConfiguration { | |||
* | |||
* @default - Query Result Location set in Athena settings for this workgroup | |||
*/ | |||
readonly outputLocation?: s3.Location; | |||
readonly outputLocation?: s3.Location | string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately using a union type here will make any other language but typescript very unusable. They just turn into an any
equivalent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you have encountered an issue and I appreciate your drive to just go an fix it! In this case however, would you mind open an issue first? This gives our triage and support team a chance to have a look at it, possibly come with a workaround and at least inform the solution better.
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Issue currently faced
I tried to do the following:
But was unable to due to an error message:
Solution
Allow
outputLocation
to receive string. Then the new parameter can also be the following:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license