Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add setter for termination protection on stack #26992

Merged
merged 5 commits into from
Sep 19, 2023
Merged

feat(core): add setter for termination protection on stack #26992

merged 5 commits into from
Sep 19, 2023

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Sep 3, 2023 •
edited
Loading

Closes #14463.
Closes #21304.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Sep 3, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 3, 2023 22:41
@msambol msambol force-pushed the setter-term-protection branch from bad4460 to e1d72fd Compare September 3, 2023 22:42
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 3, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

msambol
msambol commented Sep 3, 2023
View reviewed changes
packages/@aws-cdk-testing/framework-integ/test/core/test/integ.stack.js.snapshot/manifest.json
"environment": "aws://unknown-account/unknown-region",
"properties": {
"templateFile": "Stack.template.json",
"terminationProtection": true,
Copy link
Contributor Author

@msambol msambol Sep 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is true. the stack was initialized with false but then set to true with setter.

@aws-cdk-automation aws-cdk-automation dismissed their stale review September 3, 2023 22:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 3, 2023
@ryo0301 ryo0301 mentioned this pull request Sep 4, 2023
Closed
2 tasks
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Sep 4, 2023
@msambol
Copy link
Contributor Author

msambol commented Sep 5, 2023

@mrgrain Can I bother you for a review here ?

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Sep 14, 2023
colifran
colifran previously approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msambol Looks good!

@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 15, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mrgrain
mrgrain previously approved these changes Sep 19, 2023
View reviewed changes
@mergify mergify bot dismissed stale reviews from mrgrain and colifran September 19, 2023 10:05

Pull request has been modified.

@mrgrain
Copy link
Contributor

mrgrain commented Sep 19, 2023

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2023

update

✅ Branch has been successfully updated

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 950140f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain
Copy link
Contributor

mrgrain commented Sep 19, 2023

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 54083de into aws:main Sep 19, 2023
@msambol msambol deleted the setter-term-protection branch September 19, 2023 13:29
HBobertz pushed a commit that referenced this pull request Sep 19, 2023
@msambol
feat(core): add setter for termination protection on stack (#26992)
b58b9ce 
Closes #14463.
Closes #21304.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurelmay laurelmay laurelmay approved these changes

@mrgrain mrgrain mrgrain approved these changes

@colifran colifran colifran left review comments

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
5 participants
@msambol @mrgrain @aws-cdk-automation @laurelmay @colifran