Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include basic workspace file with jest configuration #27008

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Sep 5, 2023

The upcoming v6 of the VSCode jest plugin allows us to configure our monorepo packages as virtual folders.

This makes the built-in Test Explorer work out of the box.

image

Using the workspace is entirely optional. It can also serve as an example configurations.
But it does give a space to add recommended/opinionated VSCode settings without compromising contributor's ability to change .vscode/settings.json.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 5, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 5, 2023 09:40
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 5, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: dd20d05
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f6a5900 into main Sep 5, 2023
23 checks passed
@mergify mergify bot deleted the mrgrain/chore/workspace branch September 5, 2023 10:05
mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
The upcoming v6 of the [VSCode jest plugin](https://github.com/jest-community/vscode-jest#virtualfolders) allows us to configure our monorepo packages as virtual folders.

This makes the built-in Test Explorer work out of the box.

<img width="466" alt="image" src="https://github.com/aws/aws-cdk/assets/379814/b98b3736-4713-49d7-bec6-816f14816e73">

Using the workspace is entirely optional. It can also serve as an example configurations.
But it does give a space to add recommended/opinionated VSCode settings without compromising contributor's ability to change `.vscode/settings.json`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants