chore: replace Node16 runtimes in unit tests with symbolic runtime #27011
Conversation
To lower the effort for our next hunt-and-peck Node upgrade, replace all runtimes in unit tests with a symbolic Node version that doesn't actually have to deploy successfully.
| const THE_RUNTIME = new lambda.Runtime('nodejs99.x', lambda.RuntimeFamily.NODEJS, { | ||
| supportsInlineCode: true, | ||
| }); |
There was a problem hiding this comment.
(although it will come up in search queries and someone will curse you in ca. 40 years when node99 is released :P)
| const THE_RUNTIME = new lambda.Runtime('nodejs99.x', lambda.RuntimeFamily.NODEJS, { | ||
| supportsInlineCode: true, | ||
| }); |
There was a problem hiding this comment.
(although it will come up in search queries and someone will curse you in ca. 40 years when node99 is released :P)
|
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…27011) To lower the effort for our next hunt-and-peck Node upgrade, replace all runtimes in unit tests with symbolic Node versions. * Most of the time, use `NODEJS_LATEST` * Replace expectations of a rendered runtime `"nodejs16.x" -> Runtime.NODEJS_LATEST.name` * For tests where the hash matters, use a hardcoded fake runtime of `"node99.x"`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
To lower the effort for our next hunt-and-peck Node upgrade, replace all runtimes in unit tests with symbolic Node versions.
NODEJS_LATEST"nodejs16.x" -> Runtime.NODEJS_LATEST.name"node99.x".By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license