Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dynamodb): update CfnGlobalTable in TableV2 constructor to use this instead of scope #27075

Merged
merged 4 commits into from
Sep 8, 2023
Merged

fix(dynamodb): update CfnGlobalTable in TableV2 constructor to use this instead of scope #27075

merged 4 commits into from
Sep 8, 2023

Conversation

colifran
Copy link
Contributor

@colifran colifran commented Sep 8, 2023 •
edited
Loading

CfnGlobalTable in the constructor of TableV2 was incorrectly using scope instead of this. As a result, TableV2 was not generating correct logical IDs.

Closes #27062

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 8, 2023 20:52
@github-actions github-actions bot added bug This issue is a bug. p1 labels Sep 8, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 8, 2023
@colifran
remove unused CfnGlobalTable import
9e3b593 
Signed-off-by: Francis <colifran@amazon.com>
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@colifran colifran changed the title fix(dynamodb): update CfnGlobalTable to use this instead of scope fix(dynamodb): update CfnGlobalTable in TableV2 constructor to use this instead of scope Sep 8, 2023
@colifran colifran added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Sep 8, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 8, 2023 20:55

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@colifran
update logical id in unit tests for metrics and grants
139c655 
Signed-off-by: Francis <colifran@amazon.com>
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 139c655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 889ad8c into main Sep 8, 2023
8 checks passed
@mergify mergify bot deleted the colifran/tablev2-logical-id branch September 8, 2023 21:50
MrArnoldPalmer pushed a commit that referenced this pull request Sep 8, 2023
@colifran @MrArnoldPalmer
fix(dynamodb): update CfnGlobalTable in TableV2 constructor to use th…
afd3890 
…is instead of scope (#27075)

`CfnGlobalTable` in the constructor of `TableV2` was incorrectly using `scope` instead of `this`. As a result, `TableV2` was not generating correct logical IDs.

Closes #27062

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
@colifran
fix(dynamodb): update CfnGlobalTable in TableV2 constructor to use th…
945e03c 
…is instead of scope (#27075)

`CfnGlobalTable` in the constructor of `TableV2` was incorrectly using `scope` instead of `this`. As a result, `TableV2` was not generating correct logical IDs.

Closes #27062

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Closed
@risingfish risingfish mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dynamodb: TableV2 generates bad Logical ID
3 participants
@colifran @aws-cdk-automation @kaizencc