docs(ecs): remove restriction regarding environment files against Fargate #27081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
effort/medium
github-actions
bot
added
the
admired-contributor
aws-cdk-automation
added
the
pr/needs-community-review
mrgrain
approved these changes
Sep 9, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mikewrighton
pushed a commit
that referenced
this pull request
Sep 14, 2023
…gate (#27081) Currently, CDK document includes the following description. https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs-readme.html#environment-variables > Support for environment files is restricted to the EC2 launch type for files hosted on S3. However, this is out of date. Fargate has been [supported environment files](https://aws.amazon.com/jp/blogs/containers/latest-updates-to-aws-fargate-for-amazon-ecs/), and this restriction on CDK had been already removed by #11820. This PR removes the out of date description from document. Closes #18226 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CDK document includes the following description.
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs-readme.html#environment-variables
However, this is out of date. Fargate has been supported environment files, and this restriction on CDK had been already removed by #11820.
This PR removes the out of date description from document.
Closes #18226
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license