Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lambda): use lowercase boolean for type declarations #27082

Merged
merged 3 commits into from
Sep 9, 2023

Conversation

yodeee9
Copy link
Contributor

@yodeee9 yodeee9 commented Sep 9, 2023

Updated the type annotations to use the primitive boolean type instead of the object wrapper Boolean.
This change aligns with TypeScript's recommended naming conventions and provides clearer type indications.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 9, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 9, 2023 10:54
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Sep 9, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 9, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 37672dc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yodeee9 Please don't manually update the branch, that breaks the automation. Once a PR is approved it's best to just leave it unless it obviously stalled and maintainers don't notice it.

@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit dd93b9e into aws:main Sep 9, 2023
9 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 9, 2023
@yodeee9
Copy link
Contributor Author

yodeee9 commented Sep 10, 2023

Thank you for merging my pull request! I'll make sure not to manually update in the future.

mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
Updated the type annotations to use the primitive `boolean` type instead of the object wrapper `Boolean`. 
This change aligns with TypeScript's recommended naming conventions and provides clearer type indications.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants