Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codedeploy): CustomLambdaDeploymentConfig is broken #27087

Merged
merged 3 commits into from
Sep 11, 2023
Merged

fix(codedeploy): CustomLambdaDeploymentConfig is broken #27087

merged 3 commits into from
Sep 11, 2023

Commits on Sep 10, 2023

  1. fix(codedeploy): CustomLambdaDeploymentConfig is broken 

    Since the conversion of SDKv2 to SDKv3 of the `AwsCustomResource`,
this custom resource was broken with the following error:

```
SerializationException: STRING_VALUE can not be converted to an Integer
```

The reason is that SDKv2 used to accept strings and coerce them to
numbers wherever necessary, but SDKv3 does not do this anymore.

Update the Custom Resource usage to no longer stringify the numbers.
    @rix0rrr
    rix0rrr committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    6b4e1f4 View commit details
    Browse the repository at this point in the history

  2. Snapshot

    @rix0rrr
    rix0rrr committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    02b20da View commit details
    Browse the repository at this point in the history

  3. Unit test

    @rix0rrr
    rix0rrr committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    14b9139 View commit details
    Browse the repository at this point in the history