fix(triggers): errors are shown as list of bytes #27119
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
mrgrain
added
the
pr-linter/exempt-integ-test
|
Added |
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mrgrain
force-pushed
the
mrgrain/fix/triggers-obscure-error
branch
from
c14b39f
to
8ada370
Compare
mrgrain
force-pushed
the
mrgrain/fix/triggers-obscure-error
branch
from
8ada370
to
3dffa59
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
With Triggers a user can invoke a Lambda Function during every stack deployment. When we migrated the handler code to SDKv3, we overlooked that the return payload from the invoked lambda function is now a `Uint8Array`, and not a string anymore. In the error case, we attempt to `JSON.parse()` the error payload which then resulted in a list of bytes being returned to the user. Updated the handler test case to use correct mocks, including returning a payload that is a Uint8Array. Closes #27113 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
With Triggers a user can invoke a Lambda Function during every stack deployment.
When we migrated the handler code to SDKv3, we overlooked that the return payload from the invoked lambda function is now a
Uint8Array, and not a string anymore.In the error case, we attempt to
JSON.parse()the error payload which then resulted in a list of bytes being returned to the user.Updated the handler test case to use correct mocks, including returning a payload that is a Uint8Array.
Closes #27113
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license